Sign exploration tests image - #12140
Conversation
randomanderson
added
the
tag: no release notes
![datadog-prod-us1-3[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
The manual image-build job now invokes ddsign, but it still runs in the plain Docker 27.3.1 image and no step installs or supplies that executable. On a runner using the declared image, the build can complete and the job then fails at signing with ddsign: command not found, leaving the exploration-tests image unsigned and downstream jobs unable to use it.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 9d103ee · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d103ee7e4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
| variables: | ||
| EXPLORATION_TESTS_IMAGE: registry.ddbuild.io/ci/dd-trace-java:exploration-tests | ||
|
|
||
| build-exploration-tests-image: |
There was a problem hiding this comment.
How is this step invoked? Other test jobs depend on "build" only
There was a problem hiding this comment.
I see there is an option to manually invoke it but I don't see references for it when I even search the DD org 👀
Is it just to push an image to docker registry?
There was a problem hiding this comment.
It's manual. It's only run when the image that runs the exploration tests needs to be updated
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 16fd600: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
3 participants
What Does This Do
Use
ddsignto sign the exploration tests image.Motivation
Image signature enforcement is being applied to Gitlab CI
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]