Conversation
Bump to 0.6.1. It has no effect as this isn't the released tag. We should it every time right before a release.
Bump tracer version
Contributor
Author
|
Closing: opened against the wrong local branch due to a working-directory mix-up (not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes several OTLP trace-metrics compliance gaps in
stats_to_otlp_metrics.go, found during a cross-tracer audit against the OTel Span Metrics Connector's expected attribute conventions:process_tags: emit a singledatadog.process_tagsresource attribute (arrayValue) instead of per-keydatadog.<key>resource attributes.is_trace_root: emitdatadog.is_trace_rootas a data-point attribute, reading the previously-unusedClientGroupedStats.IsTraceRootfield.peer_tags: emitdatadog.peer_tagsas a data-point attribute (arrayValue), mirroring the same peer-tag-key allowlist the/v0.6/statspath already uses, instead of always suppressing it.additional_metric_tags: emit each configured tag as its own unprefixed data-point attribute (support for this is still evolving across most SDKs).span.kind: canonicalize to the Span Metrics Connector'sSPAN_KIND_*string convention (e.g.SPAN_KIND_SERVER) instead of the raw lowercase Datadog value.status.code: emit the Span Metrics Connector'sSTATUS_CODE_OK/STATUS_CODE_ERRORstring convention (previously an OTel int enum), unconditionally on every data point.All of the above except
additional_metric_tagsare gated by!otelMode, consistent with the existingdatadog.*attribute suppression in OTel-semantics mode.http.status_code/gRPC status handling andservice.name(already correct) are unaffected.Motivation
Companion cross-tracer fix: DataDog/system-tests#7363
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.