[CHORE] Add trace tab to Example app running React Navigation#1212
Merged
[CHORE] Add trace tab to Example app running React Navigation#1212
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the Trace tab available in the Example app when using React Navigation, and adjusts tracing debug logging so it no longer prints an unresolved Promise as [object Object].
Changes:
- Add a
Tracetab to the React Navigation bottom tab navigator in the Example app. - Update the Example
TraceScreento log the created span id. - Update
DdTrace.startSpaninternal debug logging to avoid interpolating an unresolved promise.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/trace/DdTrace.ts | Adjusts start-span debug log to avoid printing an unresolved promise. |
| example/src/screens/TraceScreen.tsx | Updates Trace screen imports and adds a debug log of the created span id. |
| example/src/App.tsx | Adds the Trace screen to the bottom tab navigator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
cdn34dd
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The trace Tab is currently only visible when running the old-arch Example app using React Native Navigation. This PR makes it available as well when using React Navigation.
It also fixes an internal log message that was attempting to print the newly generated spanId, but since at the moment of printing that value is still an unresolved promise the actual log message only displayed [object Object], which does not help much.
Review checklist (to be filled by reviewers)