Skip to content

[CHORE] Add trace tab to Example app running React Navigation#1212

Merged
sbarrio merged 1 commit intodevelopfrom
sbarrio/fix/add-trace-screen-to-rnav-example
Mar 19, 2026
Merged

[CHORE] Add trace tab to Example app running React Navigation#1212
sbarrio merged 1 commit intodevelopfrom
sbarrio/fix/add-trace-screen-to-rnav-example

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Mar 18, 2026

What does this PR do?

The trace Tab is currently only visible when running the old-arch Example app using React Native Navigation. This PR makes it available as well when using React Navigation.

It also fixes an internal log message that was attempting to print the newly generated spanId, but since at the moment of printing that value is still an unresolved promise the actual log message only displayed [object Object], which does not help much.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio self-assigned this Mar 18, 2026
@sbarrio sbarrio marked this pull request as ready for review March 18, 2026 09:24
@sbarrio sbarrio requested a review from a team as a code owner March 18, 2026 09:24
Copilot AI review requested due to automatic review settings March 18, 2026 09:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the Trace tab available in the Example app when using React Navigation, and adjusts tracing debug logging so it no longer prints an unresolved Promise as [object Object].

Changes:

  • Add a Trace tab to the React Navigation bottom tab navigator in the Example app.
  • Update the Example TraceScreen to log the created span id.
  • Update DdTrace.startSpan internal debug logging to avoid interpolating an unresolved promise.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/core/src/trace/DdTrace.ts Adjusts start-span debug log to avoid printing an unresolved promise.
example/src/screens/TraceScreen.tsx Updates Trace screen imports and adds a debug log of the created span id.
example/src/App.tsx Adds the Trace screen to the bottom tab navigator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@sbarrio sbarrio merged commit 17949da into develop Mar 19, 2026
15 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/add-trace-screen-to-rnav-example branch March 19, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants