[FIX] [V2] Babel plugin crash when handling unresolved component names#1211
Merged
cdn34dd merged 1 commit intofeature/v2from Mar 19, 2026
Merged
Conversation
cdn34dd
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes invalid JSX output produced by the React Native Babel plugin when a component name cannot be resolved, preventing crashes and ensuring generated code remains valid.
Changes:
- Update RUM JSX runtime call generation to use
Fragmentwhen the component name can’t be resolved. - Add a regression test ensuring unresolved component names don’t emit
(unknown, ...)and instead referenceFragment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-babel-plugin/src/actions/rum/index.ts | Uses Fragment from react/jsx-runtime as a safe fallback when no element name can be derived. |
| packages/react-native-babel-plugin/test/plugin.test.ts | Adds a regression test covering unresolved component name handling in getContent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marco-saia-datadog
previously approved these changes
Mar 19, 2026
Member
marco-saia-datadog
left a comment
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Looks good but refer to #1210 (review)
- Add support for JSXMemberExpression in getNodeName function
cdn34dd
force-pushed
the
carlosnogueira/issue-1209/fix-unknown-identifier-v2
branch
from
6841f94 to
2582b37
Compare
marco-saia-datadog
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FIxes invalid JSX generated when handling component names that can't be resolved.
Motivation
Issue 1209
Review checklist (to be filled by reviewers)