Change Policy.id from UUID struct to string#74
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: a95b06c | Docs | Datadog PR Page | Give us feedback! |
iamluc
left a comment
There was a problem hiding this comment.
Are you sure of the backward compatibility of this change?
Or maybe it's not filled by the UI? (https://github.com/DataDog/dd-go/blob/prod/remote-config/apps/rc-schema-validation/schemas/apm-policies.json#L193-L196)
@iamluc Good catch, I have a PR that updates |
Policy.idwas a fixed 16-byte representation, split into two uint64s as a workaround for FlatBuffers' Go codegen not supporting fixed-size arrays in structs at the time.That representation only works for real UUIDs. We want
idto also carry the sentinel value "hardcoded" for built-in/hardcoded policies (as opposed to Remote Config policies, which get a real per-rule UUID), so a single field can identify the origin of any policy regardless of source.