Skip to content

Migrate DD_API_KEY_CI_VIS_APP from GitHub secret to dd-sts#73

Open
natitsechanski wants to merge 1 commit into
mainfrom
natipirati/migrate-dd-sts
Open

Migrate DD_API_KEY_CI_VIS_APP from GitHub secret to dd-sts#73
natitsechanski wants to merge 1 commit into
mainfrom
natipirati/migrate-dd-sts

Conversation

@natitsechanski

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the long-lived DD_API_KEY_CI_VIS_APP GitHub secret with short-lived credentials from dd-sts via DataDog/dd-sts-action@v1.0.0
  • Updated 3 jobs in dev.yml: build-libpolicies-linux, build-libpolicies-windows, and coverage
  • Added id-token: write permission to each job for OIDC token federation

Prerequisites

A dd-sts policy named dd-policy-engine-ci-vis must be created and deployed in dd-source before merging this PR. The policy should be added at:

dd-source/domains/seceng/sit/apps/apis/dd-sts/config/policies/us1.ddbuild.io/dd-policy-engine-ci-vis.yaml

Example policy:

issuer: https://token.actions.githubusercontent.com

subject_pattern: "repo:DataDog/dd-policy-engine:.*"

claim_pattern:
  repository: DataDog/dd-policy-engine

org_id: 2

team: "<team-slug>"

Context

Requested by SDLC Security (Nicole) to migrate long-lived credentials in GitHub Actions to dd-sts. See dd-sts user guide.

Test plan

  • Create dd-sts policy in dd-source and get it reviewed in #sdlc-security-reviews
  • Wait for dd-sts policy deployment
  • Run this PR's CI and verify all 3 jobs (linux build, windows build, coverage) pass with dd-sts credentials
  • Remove DD_API_KEY_CI_VIS_APP secret from repo settings after merge

🤖 Generated with Claude Code

Replace the long-lived DD_API_KEY_CI_VIS_APP GitHub secret with
short-lived credentials from dd-sts via DataDog/dd-sts-action.
This addresses the SDLC Security request to migrate away from
static GitHub secrets for CI Visibility API keys.

Note: This PR requires a dd-sts policy named `dd-policy-engine-ci-vis`
to be created and deployed in dd-source first.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants