Support range partitioning - #24
Open
gene-bordegaray wants to merge 1 commit into
Open
Conversation
gene-bordegaray
changed the title
gene-bordegaray
commented
Aug 7, 2026
| match partitioning { | ||
| Partitioning::RoundRobinBatch(_) => Partitioning::RoundRobinBatch(scaled_count), | ||
| Partitioning::Hash(hash, _) => Partitioning::Hash(hash.clone(), scaled_count), | ||
| Partitioning::Range(range) if scaled_count == partition_count => { |
Author
There was a problem hiding this comment.
this is why I cant just have the default fallback paths in upstream
gene-bordegaray
force-pushed
the
gene.bordegaray/2026/08/06/range-partitioning
branch
from
August 7, 2026 14:26
32ff88a to
8e884e8
Compare
gene-bordegaray
commented
Aug 7, 2026
| @@ -165,7 +165,7 @@ mod tests { | |||
| │ DistributedUnionExec: t0:[c0(0/2)] t1:[c0(1/2)] t2:[c1(0/2)] t3:[c1(1/2)] | |||
| │ DistributedLeafExec: | |||
| │ t0: DataSourceExec: file_groups={3 groups: [[/testdata/tpcds/plans_sf1_partitions4/web_sales/part-0.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-2.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-3.parquet:<int>..<int>]]}, projection=[ws_sold_date_sk@0 as sold_date_sk, ws_ext_sales_price@23 as sales_price], file_type=parquet, predicate=DynamicFilter [ empty ] | |||
| │ t1: DataSourceExec: file_groups={3 groups: [[/testdata/tpcds/plans_sf1_partitions4/web_sales/part-0.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-2.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-2.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-3.parquet:<int>..<int>]]}, projection=[ws_sold_date_sk@0 as sold_date_sk, ws_ext_sales_price@23 as sales_price], file_type=parquet, predicate=DynamicFilter [ empty ] | |||
| │ t1: DataSourceExec: file_groups={3 groups: [[/testdata/tpcds/plans_sf1_partitions4/web_sales/part-0.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-1.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/web_sales/part-2.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/web_sales/part-3.parquet:<int>..<int>]]}, projection=[ws_sold_date_sk@0 as sold_date_sk, ws_ext_sales_price@23 as sales_price], file_type=parquet, predicate=DynamicFilter [ empty ] | |||
Author
There was a problem hiding this comment.
most of these just due to new arrow / parquet, these are generated at runtime so layout and file sizes changed a bit
gene-bordegaray
marked this pull request as ready for review
August 7, 2026 14:57
gene-bordegaray
commented
Aug 7, 2026
| @@ -942,10 +942,10 @@ mod tests { | |||
| │ [Stage 2] => NetworkBroadcastExec: partitions_per_consumer=3, stage_partitions=12, input_tasks=4 | |||
| │ RepartitionExec: partitioning=RoundRobinBatch(3), input_partitions=2 | |||
| │ DistributedLeafExec: | |||
| │ t0: DataSourceExec: file_groups={2 groups: [[/testdata/tpcds/plans_sf1_partitions4/customer_address/part-0.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/customer_address/part-1.parquet:<int>..<int>]]}, projection=[ca_address_sk, ca_zip], file_type=parquet, predicate=DynamicFilter [ empty ] AND DynamicFilter [ empty ] | |||
| │ t1: DataSourceExec: file_groups={2 groups: [[/testdata/tpcds/plans_sf1_partitions4/customer_address/part-0.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/customer_address/part-1.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/customer_address/part-2.parquet:<int>..<int>]]}, projection=[ca_address_sk, ca_zip], file_type=parquet, predicate=DynamicFilter [ empty ] AND DynamicFilter [ empty ] | |||
| │ t2: DataSourceExec: file_groups={2 groups: [[/testdata/tpcds/plans_sf1_partitions4/customer_address/part-0.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/customer_address/part-1.parquet:<int>..<int>], [/testdata/tpcds/plans_sf1_partitions4/customer_address/part-2.parquet:<int>..<int>, /testdata/tpcds/plans_sf1_partitions4/customer_address/part-3.parquet:<int>..<int>]]}, projection=[ca_address_sk, ca_zip], file_type=parquet, predicate=DynamicFilter [ empty ] AND DynamicFilter [ empty ] | |||
Author
There was a problem hiding this comment.
all the dyn fitler changes are from upstream fixes that disable dyn filters for joins with NullEqual: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding range support for cherry pick