feat: add support for event bridge DSM context extraction - #836
feat: add support for event bridge DSM context extraction#836jeastham1993 wants to merge 9 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 888ab65a55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🔗 Commit SHA: fd813a3 | Docs | View more details | Give us feedback! |
| from ddtrace.internal.datastreams import data_streams_processor | ||
| from ddtrace.internal.datastreams.processor import PROPAGATION_KEY_BASE_64 |
There was a problem hiding this comment.
We've had many problems in the past of using "internal" methods from ddtrace -- either ones in internal packages like this or ones starting with an underscore.
Are we certain that this api is stable? Do we have permission to use it? If someone tries to change it, is there a test that will fail over on the ddtrace side?
There was a problem hiding this comment.
Good question @purple4reina, let me ask the question
There was a problem hiding this comment.
I think ideally we would have a public API that allows supplying extra args such as exchange. But it doesn't exist right now. Practically it hasn't changed but there's nothing that would stop us from changing the signature because it isn't marked as a public api
Can we add an upstream change to enhance the public api? I'm not sure how the lambda versions are pinned to the python tracer
There was a problem hiding this comment.
@purple4reina @robcarlan-datadog I'm happy to do the work to upstream the change to the Python API, but is this a blocker for merging this change?
There was a problem hiding this comment.
Ideally, we wouldn't release any usage of an internal ddtrace api. But, as long as we make the changes in ddtrace then come back here to use those new public api's, I think we'd be fine. We just can't have usage of an internal api floating around without an ability to upgrade the layer past it.
|
We should eventually add a new |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fc0cd0295
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff42108b08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24da389683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 participants
What does this PR do?
Adds support for automatically extracting DSM context from Amazon Event Bridge events. Configures the DSM
exchangetag using an environment variable.Motivation
Adding DSM support for all serverless messaging technologies.
Testing Guidelines
Wrote unit test to test logical locally.
Compiled test version of layer and pushed to AWS account, tested with sample app.
Additional Notes
Types of Changes
Check all that apply