Skip to content

Add quote around expected site and dd_url value to match new example #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stanislas167 merged 4 commits into from
Jun 23, 2026
Merged

Add quote around expected site and dd_url value to match new example #433

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5773b20
Add quote around expected site and dd_url value to match new example
Stanislas167 Jun 12, 2026
062677e
Update test_install_script.sh
Stanislas167 Jun 12, 2026
580cba6
expected the value, quoted or not
Stanislas167 Jun 18, 2026
b250be6
Merge branch 'main' into stanp/2-Correct_unit_test_to_match_dd-agent_…
Stanislas167 Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unit_tests/test_install_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ testUpdateSite() {
testNoSite() {
sudo cp ${config_file}.example $config_file
update_site "sudo" "" $config_file
sudo grep -wq "^# site: datadoghq.com$" $config_file
sudo grep -wq "^# site: datadoghq.com$" $config_file || sudo grep -wq "^# site: \"datadoghq.com\"$" $config_file
assertEquals 0 $?
}

Expand All @@ -106,7 +106,7 @@ testUrlUpdated() {
testNoUrl() {
sudo cp ${config_file}.example $config_file
update_url "sudo" "" $config_file
sudo grep -wq "^# dd_url: https:\/\/app.datadoghq.com$" $config_file
sudo grep -wq "^# dd_url: https:\/\/app.datadoghq.com$" $config_file || sudo grep -wq "^# dd_url: \"https:\/\/app.datadoghq.com\"$" $config_file
assertEquals 0 $?
}

Expand Down
Loading