Repository navigation
CTM-659: add retries for eventual consistency - #495
Merged
Merged
Conversation
davidangb
commented
Oct 8, 2026
| addStep( | ||
| new CreateConsumerDefinedQuotaForBigQueryDailyUsageStep(serviceUsageCow, gcpProjectConfig)); | ||
| new CreateConsumerDefinedQuotaForBigQueryDailyUsageStep(serviceUsageCow, gcpProjectConfig), | ||
| newCloudApiDefaultRetryRule()); |
Collaborator
Author
There was a problem hiding this comment.
this is the only step in the flight that didn't have the retry rule. Adding it.
davidangb
commented
Oct 8, 2026
| // IAM policy changes may not be visible immediately, so poll until they are. | ||
| awaitEventualConsistency() | ||
| .untilAsserted( | ||
| () -> { |
Collaborator
Author
There was a problem hiding this comment.
this diff is easier to see if you hide whitespace!
|
davidangb
marked this pull request as ready for review
October 13, 2026 12:45
davidangb
requested review from
THWiseman,
aednichols,
jgainerdewar and
marctalbott
and removed request for
a team
October 13, 2026 12:45
snf2ye
approved these changes
Oct 13, 2026
aednichols
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTM-659
Three changes in this PR:
testCreateGoogleProject_createsConsumerOverrideintegration test. This test is consistently failing. It fails at the step where RBS tries to set BigQuery quota on the project it just created. This is working correctly in dev and prod; it seems to be a problem with the test environment setup, but I have not determined the root cause. The test failure is blocking release of some security updates (see CTM-659: bump TCL, which bumps bouncycastle #494). I suggest we disable the test to get the security updates out and verify in the live environments it continues to work post-release.GoogleProjectCreationFlight- all steps had a retry except this one.CreateProjectFlightIntegrationTestThe latter two changes are aimed to make integration tests less flaky. Because RBS integration tests typically take about 1 hour, any flakiness is very painful.