Skip to content

VS match picks the first invoice when two open docs share the same VS and amount #7

Closed

Description

@4ktLuffy

If two open invoices end up with the same VS (e.g. INV/2026/00001 and FAX/2026/00001 from two sale journals) and the same amount, a bank line with that VS and no known payer gets reconciled to the first one. The comment in _l10n_cssk_find_vs_counterpart_amls says it should only accept a single matching document, but the loop returns the first hit. Leaving it for a person when more than one fits would be safer. Happy to share a small test.

Activity

  1. added a commit that references this issue on Oct 24, 2026
    792f382
  2. Rad0van commented on Oct 24, 2026

    @Rad0van
    Member

    Confirmed and fixed in 792f382 (l10n_cssk_payment_symbols). No test needed from your side, thanks; the case is now in the suite.

    _l10n_cssk_find_vs_counterpart_amls now collects every document whose open amount equals the transaction, and accepts the match only when there is exactly one. Two that both fit (your INV/2026/00001 and FAX/2026/00001 case) leave the line for a person. A known payer, or an amount only one of them has, still settles it.

    The matcher is shared by the OCA and Enterprise reconciliation bridges, so the fix covers both. Tests are in l10n_cssk_payment_symbols (the matcher directly) and l10n_cssk_payment_symbols_oca (end to end through OCA's auto-reconcile).

  3. added a commit that references this issue on Oct 25, 2026
    8bbd3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions