Repository navigation
Pin the engine at 1.0.0-rc9 - #43
Merged
Merged
Conversation
rc9 is released and carries everything the command uses, so develop builds against it rather than the engine's snapshot, and the snapshot repository drops out of the build. The pin's comment and CONTRIBUTING now say so: develop pins a released engine while one has what the command needs, and returns to 1.0.0-SNAPSHOT only while it needs engine work that is not yet released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relixEngineVersionmoves from1.0.0-SNAPSHOTto the released1.0.0-rc9, so develop resolves the engine from Central alone. The pin's comment and CONTRIBUTING's engine pin bullet now describe that: develop pins a released engine while one has what the command needs, and tracks the snapshot only while it needs unreleased engine work.Verification
Against engine
1.0.0-rc9from Maven Central:./gradlew clean build --refresh-dependencies: green../gradlew checkEnginePin -PcliVersion=0.1.0: passes.