Repository navigation
Re-enable fmt's test that a blank line after a comment is kept - #40
Merged
Merged
Conversation
DarkCollective/relix-core#107 made the engine's printer keep a blank line between a comment and the statement or namespace after it, so FmtTest.Layout.blankAfterComment runs again: "-- header", a blank line, "namespace demo;", then a comment set apart from its query the same way, format to themselves.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables
FmtTest.Layout.blankAfterComment, disabled since #37 because the engine's printer dropped a blank line between a comment and the statement or namespace after it.Needs DarkCollective/relix-core#108 in the snapshot first. That PR fixes DarkCollective/relix-core#107. Until it's published, this test fails in CI.
The test formats
-- header, a blank line,namespace demo;, then-- about N, a blank line,query N;, and expects the text back unchanged. Against a local build of relix-core#108 the whole suite passes; against the current snapshot this test fails, as it should.No code changes:
fmtprints with the engine'sScriptPrinter, so the fix arrives with the engine.