fix(控制台): next must not claim ready on doctor FAIL - #55
Merged
Conversation
Treat any doctor FAIL, including missing-origin-only, as needs_repair with a scoped doctor read command. Isolated Console now loads the same next.commands source instead of an empty loader. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #54,
dyro next --format jsonon a workspace whosedoctorhas onlymissing origin/<branch>FAILs still returnedstate: "ready",commands: [], andsummary: "工作区已就绪。". Findings were extra payload. Isolated Console never saw realnext.commandsbecause_inspect_workerbuiltConsoleOverviewServicewith the default emptycommands_loader.This is CLI
next+ Isolated honesty only. ADR 0005 is unchanged: the page still cannot merge, push,--yes, or task-status.dyro startstill treats missing-origin as non-blocking.Inverted locks
tests/test_workspace.py::test_local_only_line_creates_but_doctor_and_next_are_not_readyandtests/test_cli.py::test_control_plane_next_preserves_an_explicit_workspace_selectorno longer acceptstate: "ready"+ emptycommandswhile missing-origin FAILs are attached. They now requireneeds_repair, scopeddyro --workspace ALIAS doctor,mutation_available: false, and findings present. Human text must print the FAILs and point at doctor, not 「工作区已就绪。可用 dyro start…」._inspect_workermust constructConsoleOverviewServicewithcommands_loader=next_commands._capturenow passes the registry alias into that loader. A FAIL workspace must not recommend a baredyro --workspace ALIAS, and Isolated is not stuck with empty commands while production_captureis not.Non-bootstrap FAILs (missing repo without a safe clone, symlink parent, etc.) also put doctor in
commandsso Isolated and CLI share one repair list. Bootstrap--yesstays the mutation command when it is the only applicable FAIL.Ready-path next tests that were accidentally sitting on unpublished origin (
test_next_with_one_live_objective_points_to_follow_up,test_next_with_two_live_objectives_does_not_pick_one) now publishorigin/feat/alphaso they still lock the honest ready/briefing contract.Hunch (verified)
The ready branch after
blocking_failures(which excludedis_missing_origin_finding) was the entirenextlie: missing-origin-only FAILs fell through to_workspace_ready_briefing, which hardcodesstate: "ready"andcommands: []. Isolated’s empty loader was the remaining console hole from the #54 review. Both are fixed;start()was left alone.Do not
--yes.core,core_pay,release_a,test-workspaceonly.Verify
232 passed, 16 subtests passed.