fix(会审): tighten dyro-board Record protocol - #51
Merged
Conversation
Rewrite the internal dyro-board Record protocol so a board run must declare a production-line baseline, close prior P0/P1, re-check seat claims, wait before marking 逾期未交, and record test commands from raw output. Keep the wrapper as a pointer only. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
The wait-window sentence wraps across lines in the protocol file. Assert the required phrase against collapsed whitespace so the pin does not depend on a single physical line. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
Pin 0b close-out (已闭环 / 未闭环 / same line and topic), the empty ListAgents/TaskOutput "is not enough" polarity, and test-verdict pipeline/redirect plus "must not assert pass" so delete or invert fails CI. Prior-board directory wins path clashes; negative attestation is 已检索·无先前会审; wait clock starts at first dispatch. Discipline doc now points at dyro-board/SKILL.md. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A real board run showed six holes in the 5-line Record protocol. Three of them already produced wrong written conclusions: missing production-line baseline, treating empty seat APIs as “lost”, and asserting test pass from an exit code or task-completed ping.
This PR rewrites the internal
dyro-boardRecord protocol only. Version stays on whatevermaincurrently is. It does not compete with the parallel 0.7.8 bump.What changed
dyro-board/SKILL.mdremains the single protocol file (user-invocable: false).origin/release), nevermaster/main已闭环/未闭环/须人工核, or已检索·无先前会审when none未复核·转述if unchecked)ListAgents/TaskOutputis not a dead seat逾期未交, with a named cover/dyro-review-boardstill says: followdyro-boardexactly; do not invent a second protocol. One-line pointer: protocol now requires baseline + seat lifecycle. Same-turn delivery is still refused.docs/agent-orchestration-discipline.mdno longer lists the old five-line template; it points atdyro-board/SKILL.md.0b, flipping “is not enough” to “is enough”, or inverting “must not assert pass” / droppingpipeline/redirect hid the exit codefails CI. Hide-board tests stay: help has no/dyro-board/$dyro-board;user-invocable: false.Kept
--yes.须人工核for unprovable claims.task reviewPASS.Verification
Polarity helpers in
tests/test_integrations.pyalso assert the inverted copies fail: drop0b, delete已闭环/未闭环, flip “is not enough” → “is enough”, invert “must not assert pass”, or delete “pipeline/redirect hid the exit code”. Version inpyproject.tomlis still0.7.7.Out of scope