Skip to content

fix(会审): tighten dyro-board Record protocol - #51

Merged
Dandre126 merged 3 commits into
mainfrom
cursor/dyro-board-record-protocol-3af3
Aug 20, 2026
Merged

fix(会审): tighten dyro-board Record protocol#51
Dandre126 merged 3 commits into
mainfrom
cursor/dyro-board-record-protocol-3af3

Conversation

@Dandre126

@Dandre126 Dandre126 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Why

A real board run showed six holes in the 5-line Record protocol. Three of them already produced wrong written conclusions: missing production-line baseline, treating empty seat APIs as “lost”, and asserting test pass from an exit code or task-completed ping.

This PR rewrites the internal dyro-board Record protocol only. Version stays on whatever main currently is. It does not compete with the parallel 0.7.8 bump.

What changed

  • dyro-board/SKILL.md remains the single protocol file (user-invocable: false).
  • Record protocol now requires:
    • per-repo diff baseline defaulting to the production line (usually origin/release), never master/main
    • close-out of prior P0/P1 on the same development line / same topic as 已闭环 / 未闭环 / 须人工核, or 已检索·无先前会审 when none
    • existing review-directory convention when one exists; if that clashes with a prior-board directory on the same line, the prior-board directory wins
    • chair re-check of every seat claim (未复核·转述 if unchecked)
    • explicit wait window (≥ 10 minutes) starting at first dispatch, not the first empty poll; empty ListAgents / TaskOutput is not a dead seat
    • missed seats are 逾期未交, with a named cover
    • late reports require a revised record
    • test verdicts record the full command, the raw-output summary line, and whether a pipeline/redirect hid the exit code; exit code or a task-completed notification must not assert pass
  • /dyro-review-board still says: follow dyro-board exactly; do not invent a second protocol. One-line pointer: protocol now requires baseline + seat lifecycle. Same-turn delivery is still refused.
  • docs/agent-orchestration-discipline.md no longer lists the old five-line template; it points at dyro-board/SKILL.md.
  • Tests pin the new required phrases and their polarities. Deleting 0b, flipping “is not enough” to “is enough”, or inverting “must not assert pass” / dropping pipeline/redirect hid the exit code fails CI. Hide-board tests stay: help has no /dyro-board / $dyro-board; user-invocable: false.
  • CHANGELOG Unreleased bullet only. No version bump, no merge, no tag.

Kept

  • Not a mutation: Go does not authorize merge / push / publish / --yes.
  • 须人工核 for unprovable claims.
  • Record is not Proof and not task review PASS.
  • P0/P1/P2 + Go/No-Go output contract.
  • Each reviewer writes only in a signed section.

Verification

uv run ruff check src tests experiments
# All checks passed

uv run python -m unittest tests.test_integrations tests.test_seats -v
# Ran 55 tests in 0.931s
# OK

Polarity helpers in tests/test_integrations.py also assert the inverted copies fail: drop 0b, delete 已闭环/未闭环, flip “is not enough” → “is enough”, invert “must not assert pass”, or delete “pipeline/redirect hid the exit code”. Version in pyproject.toml is still 0.7.7.

Out of scope

  • Version bump / release tagging (see the separate 0.7.8 PR).
  • Copying the protocol into the wrapper.
  • Customer names, product-repo names, or personal machine paths.
Open in Web Open in Cursor 

Rewrite the internal dyro-board Record protocol so a board run must
declare a production-line baseline, close prior P0/P1, re-check seat
claims, wait before marking 逾期未交, and record test commands from
raw output. Keep the wrapper as a pointer only.

Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dyro Error Error Aug 20, 2026 8:09pm
dyro-engineering-flow Error Error Aug 20, 2026 8:09pm

The wait-window sentence wraps across lines in the protocol file.
Assert the required phrase against collapsed whitespace so the pin
does not depend on a single physical line.

Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
Pin 0b close-out (已闭环 / 未闭环 / same line and topic), the empty
ListAgents/TaskOutput "is not enough" polarity, and test-verdict
pipeline/redirect plus "must not assert pass" so delete or invert
fails CI. Prior-board directory wins path clashes; negative
attestation is 已检索·无先前会审; wait clock starts at first
dispatch. Discipline doc now points at dyro-board/SKILL.md.

Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
@Dandre126
Dandre126 marked this pull request as ready for review August 20, 2026 20:15
@Dandre126
Dandre126 merged commit 0145cb4 into main Aug 20, 2026
9 of 11 checks passed
@Dandre126
Dandre126 deleted the cursor/dyro-board-record-protocol-3af3 branch August 20, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants