docs: 2026-08-20 line remote-ready design review - #41
Closed
Dandre126 wants to merge 1 commit into
Closed
Conversation
Review-only note: D-01 through D-06 still exist on 6986f63 / 0.7.6. Verdict is fix-the-design. No product-code changes and no version bump. Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review-only pass against
mainat6986f63(0.7.6). No product-code changes and no version bump.The note is
docs/reviews/2026-08-20-line-remote-ready-design-review.md.Findings
All six expected defects are still present on this checkout:
_plan_line_creationstill doesgit worktree add -b <line.branch> <dest> <parent-base>and never bindsorigin/<line.branch>.doctorstill only checks worktree / branch name / common-dir (or anchor symlink).cmd_nextstill treats zero FAIL as ready.--workspace /abs/pathstill hitsvalidate_id. Textnextstill mapsValidationErrorto “尚未发现工作区” and returns exit 0.allow_push=falsestill only gatestask merge --push. status/next do not disclose that rawgit pushstill works.assert_projections_allow_mutationstill returns when projections were never compiled.Verdict
fix-the-design — do not implement the local
fix/line-remote-readynote as written.P0 before coding:
apply_join_plan) currently fails the whole join on any doctor FAIL after mutation. SHA-pinned blueprint lines are not required to haveorigin/<line.branch>. The design must say whether join ignores missing-origin, requires the remote branch, or keeps structural checks only.@{upstream}is the parent ref, notHEADSHA equals the base. Otherwise home-open cannot enter a new--no-trackline.P1 includes: no fetch (stale remote-tracking refs),
nextreusing “还不能开始任务” for a healthy local line, home-open exception width (start/open/task), hotfix and non-feat/branch names,anchor-reference, tests that still encode the old ready / fail-open predicate, and the blanket textnextValidationErrorhandler.The intended direction (track origin when present,
--no-trackotherwise, discloseallow_push, fail-closed supervised apply) is the right shape after those two sentences exist.