Skip to content

docs: 2026-08-20 line remote-ready design review - #41

Closed
Dandre126 wants to merge 1 commit into
mainfrom
cursor/line-remote-ready-review-7abb
Closed

docs: 2026-08-20 line remote-ready design review#41
Dandre126 wants to merge 1 commit into
mainfrom
cursor/line-remote-ready-review-7abb

Conversation

@Dandre126

Copy link
Copy Markdown
Contributor

Review-only pass against main at 6986f63 (0.7.6). No product-code changes and no version bump.

The note is docs/reviews/2026-08-20-line-remote-ready-design-review.md.

Findings

All six expected defects are still present on this checkout:

  • D-01 _plan_line_creation still does git worktree add -b <line.branch> <dest> <parent-base> and never binds origin/<line.branch>.
  • D-02 doctor still only checks worktree / branch name / common-dir (or anchor symlink). cmd_next still treats zero FAIL as ready.
  • D-03 --workspace /abs/path still hits validate_id. Text next still maps ValidationError to “尚未发现工作区” and returns exit 0.
  • D-04 Alias match is still exact and case-sensitive, with no close-match hint.
  • D-05 allow_push=false still only gates task merge --push. status/next do not disclose that raw git push still works.
  • D-06 assert_projections_allow_mutation still returns when projections were never compiled.

Verdict

fix-the-design — do not implement the local fix/line-remote-ready note as written.

P0 before coding:

  1. Join completion (apply_join_plan) currently fails the whole join on any doctor FAIL after mutation. SHA-pinned blueprint lines are not required to have origin/<line.branch>. The design must say whether join ignores missing-origin, requires the remote branch, or keeps structural checks only.
  2. “upstream/HEAD is parent” must mean @{upstream} is the parent ref, not HEAD SHA equals the base. Otherwise home-open cannot enter a new --no-track line.

P1 includes: no fetch (stale remote-tracking refs), next reusing “还不能开始任务” for a healthy local line, home-open exception width (start/open/task), hotfix and non-feat/ branch names, anchor-reference, tests that still encode the old ready / fail-open predicate, and the blanket text next ValidationError handler.

The intended direction (track origin when present, --no-track otherwise, disclose allow_push, fail-closed supervised apply) is the right shape after those two sentences exist.

Open in Web Open in Cursor 

Review-only note: D-01 through D-06 still exist on 6986f63 / 0.7.6.
Verdict is fix-the-design. No product-code changes and no version bump.

Co-authored-by: Dandre Yang <Dandre126@users.noreply.github.com>
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dyro Error Error Aug 20, 2026 10:08am
dyro-engineering-flow Error Error Aug 20, 2026 10:08am

@Dandre126

Copy link
Copy Markdown
Contributor Author

关闭:这是对 0.7.6 @ 6986f63 的只读复核笔记。D-01–D-06 已在 #42 / 0.7.7 合入 main,笔记不再反映当前代码。

@Dandre126 Dandre126 closed this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants