Click-casting: resolve spec-replacement spell overrides at macro build time#64
Open
doug-w wants to merge 1 commit into
Open
Click-casting: resolve spec-replacement spell overrides at macro build time#64doug-w wants to merge 1 commit into
doug-w wants to merge 1 commit into
Conversation
…d time When generating /cast macros, distinguish proc-style overrides (e.g. Flash of Light -> Benediction) from spec-replacement overrides (e.g. Remove Corruption -> Nature's Cure). For proc-style, keep the base name so /cast remains valid when the proc expires; for spec replacements, use the override name since the base spell is not in the spellbook for that spec. Detect via C_SpellBook.IsSpellInSpellBook with includeOverrides=false: if the base is directly in the book it's proc-style, otherwise resolve through C_Spell.GetOverrideSpell. ApplyBindings already runs on ACTIVE_PLAYER_SPECIALIZATION_CHANGED / TRAIT_CONFIG_UPDATED, so macros regenerate when the resolution changes. Fixes DanderBot#63 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C_SpellBook.IsSpellInSpellBook(..., includeOverrides=false). Resolve to the override name only in the spec-replacement case so proc behavior is preserved.ApplyBindingsalready runs onACTIVE_PLAYER_SPECIALIZATION_CHANGED/TRAIT_CONFIG_UPDATED, so macros regenerate when the resolution would change.Test plan
🤖 Generated with Claude Code