Add Maelstrom to resource bar color options#56
Open
Rubyj wants to merge 1 commit into
Open
Conversation
Author
|
@DanderBot anything else needed here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds Maelstrom to the list of configurable resource bar colors in the Resource Bar settings page (Bars > Resource Bar > Resource Colors).
Why?
Shamans use the Maelstrom resource type, which was not included in the
POWER_LISTused to generate color pickers. Users who set all listed resource colors (e.g. to black) would still see Shaman resource bars rendered in Blizzard's default blue, because there was no override entry for theMAELSTROMtoken.Changes
Options/Options.lua— Added{ token = "MAELSTROM", name = L["Maelstrom"] }toPOWER_LISTLocales/enUS.lua— AddedL["Maelstrom"] = true(alphabetically sorted)No new settings keys, no migration needed, no logic changes. Follows the identical pattern used by all other power types. The existing
GetPowerColor, profile export/import, and Reset All to Default button all handle Maelstrom automatically once it's in the list.