Drag-to-reorder bindings in the Click-Casting Active Bindings list#38
Open
azjthomasfamily wants to merge 1 commit into
Open
Drag-to-reorder bindings in the Click-Casting Active Bindings list#38azjthomasfamily wants to merge 1 commit into
azjthomasfamily wants to merge 1 commit into
Conversation
azjthomasfamily
force-pushed
the
feat/reorder-bindings
branch
2 times, most recently
from
0f1991d to
9198e9e
Compare
azjthomasfamily
force-pushed
the
feat/reorder-bindings
branch
6 times, most recently
from
e2abdca to
8668ff2
Compare
Adds a thin drag handle on the left edge of each binding row. Clicking and dragging the handle shows a floating ghost that follows the cursor plus an insert-position line, letting users reorder bindings in whatever order they prefer (e.g. Left / Middle / Right, then modified variants) instead of the chronological add order. Disabled bindings keep their original slots; reordering only shuffles the visible set and merges back into db.bindings. After drop: ApplyBindings, RefreshActiveBindings, RefreshSpellGrid — same flow used by the delete button.
azjthomasfamily
force-pushed
the
feat/reorder-bindings
branch
from
8668ff2 to
d8970d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.bindingsApplyBindings→RefreshActiveBindings→RefreshSpellGridWhy
The list today reflects the chronological order bindings were added. This lets users group them logically (e.g. Left / Middle / Right, then modifier variants).
Test plan
Notes
L["Drag to reorder"]## [Unreleased]