Unified border system + border animations#119
Open
Krathe82 wants to merge 2 commits into
Open
Conversation
…tling Route every border (frame, square/icon, bar, defensive icon, missing buff, resource bar, pet, targeted spells) through a single DF.Border engine with shared style / alpha / gradient controls and 10 animation effects (LibCustomGlow embedded). Add DF.Expiring with per-entry throttle + stagger for the expiring border ticker. Defensive-icon and missing-buff border fixes (frame level, co-planar with the icon, out-of-range fade preserved across re-renders). Adds the border & expiry system overview docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes every border through one engine (
DF.Border) with consistent Style / Colour / Alpha / Gradient controls — the frame border, buff/debuff aura icons, aura bars, defensive icons, missing-buff, resource bar, pet frames and targeted spells all share the same border code and options.Highlights
CreateBorderControls) reused across every element.DF.Expiring) with per-entry throttle/stagger to keep overhead low when many borders are expiring at once.Fixes included
Notes
Libs/LibCustomGlow-1.0(drives the glow animations).docs/border-expiry-system.md.Frames/Border.lua/Frames/Expiring.lua; the rest is wiring + options.First of a sequenced set: borders → defaults → fixes → icons.