Repository navigation
test: check the nightly image test keeps the starter template and a hung build's errors - #778
Merged
danathar-atomic-hive[bot] merged 1 commit intoOct 20, 2026
Conversation
The nightly boot test builds its project through App.write_local_build_context(), and its timeout branches decode what the command printed through timed_out_output(). Nothing failed when the seed step was dropped from the first, or when the second lost stderr, swapped the streams or decoded strictly. Check that the generated context holds every file the bundled template ships and every path its Containerfile copies, and that a timed-out build's log keeps stdout then stderr with a byte that is not UTF-8 replaced. Closes #777 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: quality <320561496+danathar-atomic-hive[bot]@users.noreply.github.com>
danathar-atomic-hive
Bot
added
author/hive
Contributor
Author
danathar-atomic-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The nightly check that builds and boots sample images had two blind spots in its tests. If the sample project stopped including the starter template files, or if a hung build's error messages were dropped or crashed the check, every test still passed. This adds tests that fail in both cases.
Test Improvement
Adds three tests to
tests/test_variant_boot_test.py:test_the_project_starts_from_the_bundled_template: for a Containerfile slot and a BlueBuild slot, every file the bundled template snapshot ships (minus.template-sourceandrenovate.json5, whichcopy_template_snapshot()ignores) is in the generated context.test_every_path_the_containerfile_copies_is_in_the_project: eachCOPYsource in the generated Containerfile is a directory in the context.test_a_timed_out_build_keeps_its_stderr_and_bytes_that_are_not_utf8: aTimeoutExpiredwith bothoutput=andstderr=, the stderr holding\xff; the log starts with stdout then stderr, with the byte as U+FFFD.Closes #777
Evidence
Mutants over the lines #769 and #771 changed, each run against
test_variant_boot_test.pyandtest_atomic_image_builder.py: 11/16 caught onmain(4080b64), 15/16 with this PR. Newly caught: seed step dropped, stderr dropped, streams swapped, strict decode. Left:include_workflow=Trueinwrite_local_build_context(), which podman never reads (reason in #777).python3 -m unittest discover -s tests: Ran 2619, OK (skipped=50).ruff check(0.16.5): all checks passed.No production code changes.
Filed by quality agent (ACMM L4/L6 — full mode)
🤖 Generated with Claude Code
— hive: agent=quality backend=claude model=claude-opus-5-5 effort=high claude=2.1.304