Fix potential Longtail_GetFilesRecursively2 buffer overrun.#252
Merged
DanEngelbrecht merged 3 commits intoJun 28, 2025
Merged
Conversation
DanEngelbrecht
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Longtail_GetFilesRecursively2when using a Job API.IncludeFoundFilewhere as setup ofjob_contextsdoes not. This can lead to length inconsistencies. I managed to expose this by excluding certain directories via Regex (throughgolongtailCLI) which meant thatLONGTAIL_FATAL_ASSERT(ctx, job_index == job_count, return ENOMEM);is hit when runninggolongtailwith a debug static library (job_index > job_count). If not debug, exits with code0xc0000374.