Update ChangeVersion2 to handle permission changes#249
Closed
chris-believer wants to merge 5 commits into
Closed
Conversation
Not certain if this is specific to the test or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
My initial attempt at adding a
SetPermissionscall inRetainPermissionscaused theVersionDifftest to fail due to an a trailing slash on thefull_path. Checkingversion_storage_api->IsDirdid not return true, potentially due to the trailing slash as well? I added a check to strip the trailing slash inRetainPermissions, but if this is due to something in the test setup it may be better fixed there.The call to
RetainPermissionswhenblock_write_infos == 0feels mostly unnecessary in practice, but seems correct if theversion_diffcould produce any diffs that do not also include block writes.