Skip to content

refactor(windows): start experimental application/controller layer - #70

Closed
Dailin521 wants to merge 2 commits into
mainfrom
agent/application-controller-phase-1
Closed

refactor(windows): start experimental application/controller layer#70
Dailin521 wants to merge 2 commits into
mainfrom
agent/application-controller-phase-1

Conversation

@Dailin521

@Dailin521 Dailin521 commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Goal

Start Phase 1 with a UI-independent Application/controller seam that is exercised by the real Windows GUI.

This replaces #62's docs-first stable JSONL v1/UI-probe proposal with an experimental 0.x architecture. No public protocol or compatibility contract is introduced here.

What changed

  • add cross-platform CodexProviderSync.Application and focused controller tests
  • use typed snapshots, commands, provider state, model modes, validation, and immutable sync/switch requests
  • route WinForms initialization/refresh, Provider selection, model choices, and sync/switch request mapping through the controller
  • freeze execution inputs before any await, preventing model/provider drift while an operation is running
  • fall back to the current Provider when a saved selection no longer exists
  • reject concurrent controller operations and build each request from one atomic snapshot
  • block Execute/Restore after a failed refresh, especially when the user changed Codex Home
  • run Application tests in CI and the Release build
  • document the non-normative automation direction in docs/AUTOMATION_DESIGN_NOTES.md

Explicitly out of scope

  • an Automation executable
  • JSONL, a published schema, or stable v1 fields/error codes
  • plan IDs or a plan/execute protocol
  • a UI inspect/capture probe
  • release packaging changes
  • macOS GUI migration
  • restore/prune controller migration

Verification

  • npm test — 110/110
  • node scripts/verify-release-version.js --tag v0.3.2
  • git diff --check
  • independent static review with no remaining blockers
  • Windows/macOS .NET CI — run #132
  • manual Windows smoke check of refresh, Provider selection, sync, and switch

The first CI attempt exposed a namespace collision in Program.cs; commit b4308ee fixes it by explicitly qualifying the WinForms Application type. The full rerun is green.

This remains Draft until the manual Windows smoke check is complete.

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: b4308ee73d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dailin521

Copy link
Copy Markdown
Owner Author

Superseded by the completed v0.4 integration in #71, which preserves and extends this Application/Controller baseline. Closing this Draft without merging.

@Dailin521 Dailin521 closed this Aug 4, 2026
@Dailin521
Dailin521 deleted the agent/application-controller-phase-1 branch August 4, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant