refactor(windows): start experimental application/controller layer - #70
Closed
Dailin521 wants to merge 2 commits into
Closed
refactor(windows): start experimental application/controller layer#70Dailin521 wants to merge 2 commits into
Dailin521 wants to merge 2 commits into
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
Superseded by the completed v0.4 integration in #71, which preserves and extends this Application/Controller baseline. Closing this Draft without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Start Phase 1 with a UI-independent Application/controller seam that is exercised by the real Windows GUI.
This replaces #62's docs-first stable JSONL v1/UI-probe proposal with an experimental 0.x architecture. No public protocol or compatibility contract is introduced here.
What changed
CodexProviderSync.Applicationand focused controller testsawait, preventing model/provider drift while an operation is runningdocs/AUTOMATION_DESIGN_NOTES.mdExplicitly out of scope
Verification
npm test— 110/110node scripts/verify-release-version.js --tag v0.3.2git diff --checkThe first CI attempt exposed a namespace collision in
Program.cs; commitb4308eefixes it by explicitly qualifying the WinFormsApplicationtype. The full rerun is green.This remains Draft until the manual Windows smoke check is complete.