Scheduled weekly dependency update for week 36 - #721
Conversation
📝 WalkthroughWalkthroughThe pull request updates pinned documentation and development dependency versions. It changes nine dependency pins and leaves ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🟡 Moderate · up to This dependency update makes the development requirements unavailable on the supported Python 3.9 test environment, causing that CI job to fail before tests run. Update the supported Python matrix or use Python 3.9-compatible pins before merging. Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 597b8586-51ba-4442-9af4-990ecde320d4
📒 Files selected for processing (2)
docs/requirements-docs.txtrequirements-dev.txt
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: build (3.10)
- GitHub Check: build (3.13)
- GitHub Check: build (3.12)
- GitHub Check: build (3.11)
🔇 Additional comments (3)
requirements-dev.txt (3)
1-1: LGTM!Also applies to: 3-3, 5-6, 9-9
7-7: 🗄️ Data Integrity & IntegrationExercise the FiftyOne visualization path with
fiftyone==1.21.0.With a non-empty
QueryResult, confirmfo.Dataset,fo.Sample,Dataset.merge_samples(samples), andfo.launch_app(ds)complete successfully.
2-2: 🩺 Stability & Availability
pytest.yield_fixtureremains available in pytest 9.1.1. Its deprecation does not establish apytest-git==1.8.0compatibility failure.
| sphinx-sitemap==2.9.0 | ||
| sphinx-click==6.2.0 | ||
| sphinx-autodoc-typehints==3.9.9 | ||
| sphinx-autodoc-typehints==3.13.5 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🤖 get_repo_knowledge executed:
get_repo_knowledge DagsHub/client /tmp/coderabbit-repo-knowledge/dagshub-client-aa1863f7
Length of output: 391
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- changed requirement files ---'
cat -n docs/requirements-docs.txt
printf '%s\n' '---'
cat -n requirements-dev.txt
printf '%s\n' '--- Python/version metadata candidates ---'
rg -n --glob '!*.lock' --glob '!dist/**' --glob '!build/**' \
'python_requires|requires-python|python-version|3\.[0-9]+|Python [0-9]|actions/setup-python|tox|nox|pytest|sphinx' \
pyproject.toml setup.cfg setup.py tox.ini noxfile.py .github docs README.md 2>/dev/null || trueRepository: DagsHub/client
Length of output: 8740
🌐 Web query:
PyPI sphinx-autodoc-typehints 3.13.5 pytest 9.1.1 fiftyone 1.21.0 datasets 5.0.1 Requires-Python
💡 Result:
The Requires-Python specifications for the requested packages are as follows: - sphinx-autodoc-typehints (v3.13.5): >=3.12 [1] - pytest (v9.1.1): >=3.10 [2][3] - fiftyone (v1.21.0): >=3.10 [4][5] - datasets (v5.0.1): >=3.10.0 [6] These requirements define the minimum Python version needed to install and run each respective package version.
Citations:
- 1: https://pypi.org/project/sphinx-autodoc-typehints/3.13.5/
- 2: https://pypi.org/project/pytest/9.1.1/
- 3: https://pypi.org/project/pytest/
- 4: https://pypi.org/project/fiftyone/1.21.0/
- 5: https://pypi.org/project/fiftyone/
- 6: https://pypi.org/project/datasets/5.0.1/
🏁 Script executed:
#!/bin/bash
set -eu
printf '%s\n' '--- test workflow ---'
cat -n .github/workflows/python-package.yml
printf '%s\n' '--- docs workflow ---'
cat -n .github/workflows/docs-publish.yml
printf '%s\n' '--- setup metadata ---'
sed -n '1,95p' setup.py
printf '%s\n' '--- requirement installation references ---'
rg -n -C 3 'requirements-dev|requirements-docs|pip install|pytest|sphinx-build' .github Makefile docs/Makefile docs/make.bat 2>/dev/null || trueRepository: DagsHub/client
Length of output: 11845
Make the development requirements compatible with Python 3.9.
python-package.yml installs requirements-dev.txt on Python 3.9–3.13. pytest==9.1.1, fiftyone==1.21.0, and datasets==5.0.1 require Python 3.10 or newer, so the Python 3.9 job cannot install them. Pin compatible versions or remove Python 3.9 from the supported matrix and package metadata. Keep the documentation workflow on Python 3.12 or newer because sphinx-autodoc-typehints==3.13.5 requires it.
📍 Affects 2 files
docs/requirements-docs.txt#L7-L7(this comment)requirements-dev.txt#L2-L2requirements-dev.txt#L7-L8
1 participant
Update sphinx-autodoc-typehints from 3.9.9 to 3.13.5.
Changelog
3.13.5
3.13.4
3.13.3
3.13.2
3.13.1
3.13.0
3.12.1
3.12.0
3.11.1
3.11.0
3.10.6
3.10.5
3.10.4
3.10.3
3.10.2
3.10.1
3.10.0
3.9.11
3.9.10
Links
Update setuptools from 80.9.0 to 84.0.0.
Changelog
84.0.0
83.0.0
82.0.1
82.0.0
81.0.0
80.10.2
80.10.1
80.10.0
Links
Update pytest from 8.3.5 to 9.1.1.
Changelog
9.1.1
9.1.0
9.0.3
9.0.2
9.0.1
9.0.0