Adding Optional Second button and function#44
Adding Optional Second button and function#44CaptainJeff wants to merge 4 commits intoDaftMonk:masterfrom
Conversation
Added a secondLabelText and secondLabelFunction that lets you pass secondLabelText for the name of the button and secondLabelFunction as the function you want to call
Adding styling to the new button
Adding the documentation for secondLabelText and secondLabelFunction
Adding width sizes for buttons
|
Hi @CaptainJeff - This sounds like a potentially good feature, but I'll need a couple of things from you before I can look at it further. Looks like you modified one of the dynamically built amalgamations rather than the upstream source ( Thanks and let me know if you have any questions. |
|
Will do man, didn't realize I should be changing that /src/tour/tour.js file. I also changed quite a bit. I added a few optional features. Some would call functions, others would just be a href, and there were some styling features. I'll re-do this and submit again. It'll probably take me a few days or a week. |
|
Sounds good! If you have multiple independent features you'd like to get in, it'd make more sense to do individual PRs. You can always keep a private fork and cherry-pick individual commits as needed to support your project in the meantime. |
|
Hey @CaptainJeff - Just seeing if you would like to clean up this PR (or file a new one). Thanks! |
2 participants
This fork lets you add an optional button next to the "Next" button. This lets you call a function on a specific button which lets the tour be more interactive