Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Enforce Trusted Types for DOM XSS protection - #143

Open
keough99 wants to merge 1 commit into
mainfrom
sentinel-trusted-types-15212737099801990996
Open

πŸ›‘οΈ Sentinel: [HIGH] Enforce Trusted Types for DOM XSS protection#143
keough99 wants to merge 1 commit into
mainfrom
sentinel-trusted-types-15212737099801990996

Conversation

@keough99

Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The static HTML pages lacked Trusted Types enforcement, which could allow DOM-based XSS attacks if an injection vulnerability is ever discovered.
🎯 Impact: Without Trusted Types, attackers who manage to inject malicious strings into DOM sinks could execute arbitrary scripts.
πŸ”§ Fix: Added require-trusted-types-for 'script'; trusted-types 'none'; to the <meta http-equiv="Content-Security-Policy"> tags to completely block all DOM-based XSS attacks since the application does not dynamically evaluate strings or use unsafe DOM sinks.
βœ… Verification: Run the automated tests (test_click_copy.py and test_skip_link.py) to verify that the strict CSP does not break any functionality.


PR created automatically by Jules for task 15212737099801990996 started by @keough99

Added require-trusted-types-for 'script'; trusted-types 'none'; to the Content-Security-Policy meta tags in all HTML files to block DOM-based XSS attacks.

Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant