Skip to content

πŸ›‘οΈ Sentinel: Enhance CSP with Trusted Types for DOM XSS prevention - #139

Open
keough99 wants to merge 1 commit into
mainfrom
sentinel-csp-trusted-types-4433260376103841557
Open

πŸ›‘οΈ Sentinel: Enhance CSP with Trusted Types for DOM XSS prevention#139
keough99 wants to merge 1 commit into
mainfrom
sentinel-csp-trusted-types-4433260376103841557

Conversation

@keough99

Copy link
Copy Markdown
Contributor

🚨 Severity: ENHANCEMENT
πŸ’‘ Vulnerability: Missing protection against DOM-based XSS via unsafe sinks.
🎯 Impact: A malicious script or future vulnerable code change could exploit DOM sinks (like innerHTML) to execute arbitrary JavaScript, potentially leading to XSS.
πŸ”§ Fix: Enhanced the Content-Security-Policy to include require-trusted-types-for 'script' and trusted-types 'none', which completely disables unsafe DOM sinks since the static site safely relies on textContent.
βœ… Verification: Run the Python test suite and confirm that the site remains functional without console errors, and verify the CSP string in HTML headers.


PR created automatically by Jules for task 4433260376103841557 started by @keough99

Adds require-trusted-types-for 'script' and trusted-types 'none' to
the Content Security Policy across all static HTML files to protect
against potential DOM-based Cross-Site Scripting (XSS).

Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant