π‘οΈ Sentinel: [CRITICAL] Fix exposed credentials in database setup command - #92
π‘οΈ Sentinel: [CRITICAL] Fix exposed credentials in database setup command#92keough99 wants to merge 1 commit into
Conversation
Commands accepting sensitive information like database passwords as plaintext arguments must be restricted to Direct Messages (DMs) to prevent credential leakage in public server channels. Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
levelerdb setupcommand in thelevelercog accepts a database password as a plaintext argument. If this command is run in a public server channel, it exposes the credentials to all members and permanently logs them in Discord's message history.π― Impact: Unauthorized users or attackers in the server could obtain the database credentials and compromise the backend MySQL database.
π§ Fix: Added a
ctx.guildcheck to thelevelerdb setupcommand. If the command is executed in a server channel, the bot attempts to delete the message (to hide the credentials) and returns an error instructing the user to run the command in Direct Messages (DMs).β Verification:
[p]levelerdb setup localhost user password db 3306in a server channel. The bot should delete the message and respond with an error.PR created automatically by Jules for task 6755986826014647749 started by @keough99