π‘οΈ Sentinel: [CRITICAL] Fix credential exposure in database setup command - #88
Conversation
β¦mand Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
levelerdb setupcommand in thelevelercog accepted plain-text MySQL credentials (including passwords) in public server channels, exposing these credentials in the channel's chat history.π― Impact: Unauthorized users in the channel could view the bot owner's database credentials, leading to a complete compromise of the backend database.
π§ Fix: Modified
levelerdb_setupto explicitly checkif ctx.guild:and enforce execution in Direct Messages. If accidentally run in a public channel, the command attempts to delete the user's message (await ctx.message.delete()) to prevent credential leakage and returns a warning.β Verification: Tested syntax compilation of
leveler/commands.pyand ensured tests pass.PR created automatically by Jules for task 9186182412396689472 started by @keough99