π‘οΈ Sentinel: [CRITICAL] Fix database credential exposure in chat history - #83
π‘οΈ Sentinel: [CRITICAL] Fix database credential exposure in chat history#83keough99 wants to merge 1 commit into
Conversation
Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
[p]levelerdb setupcommand accepted MySQL database credentials (including the password) as plaintext arguments. Because it didn't restrict execution to Direct Messages, these credentials could be exposed in a public server's message history if an admin ran the command incorrectly.π― Impact: An attacker could scrape or view the server's message history to obtain the MySQL database credentials, leading to a complete compromise of the database and its user data.
π§ Fix: Added a
ctx.guildcheck tolevelerdb_setup. If executed in a public channel, it gracefully handles deletion of the message (maskingHTTPExceptionif permissions lack) and directs the user to rerun the command securely in Direct Messages.β Verification: Verified syntax using
py_compileand tested database logic inleveler/test_db.py. Checked against standard Discord API boundaries.PR created automatically by Jules for task 7655948427908853368 started by @keough99