π‘οΈ Sentinel: [Medium] Fix Missing guild_only decorators on guild-dependent commands - #81
π‘οΈ Sentinel: [Medium] Fix Missing guild_only decorators on guild-dependent commands#81keough99 wants to merge 1 commit into
Conversation
β¦ndent commands Several commands in the Leveler cog (`profile`, `bio`, `top`, `levelshop`, `resetrank`, `levelset`) accessed `ctx.guild` without the `@commands.guild_only()` decorator. If executed in a Direct Message (DM), `ctx.guild` is `None`, leading to an `AttributeError` and unhandled exceptions. This commit adds `@commands.guild_only()` decorators to these commands to restrict their execution to guilds and prevent potential stack trace leakage. Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: Medium
π‘ Vulnerability: Missing
guild_onlydecorator on commands requiring server context (ctx.guild).π― Impact: Invoking these commands in a Direct Message (DM) causes an
AttributeError(sincectx.guildisNone), leading to an unhandled application exception and potential stack trace information leakage to the user.π§ Fix: Added
@commands.guild_only()toprofile,bio,top,levelshop,resetrank, andlevelsetinleveler/commands.py.β Verification: Code syntax verified via
py_compile. Commands will now be safely rejected if invoked in a DM.PR created automatically by Jules for task 11541368955637625762 started by @keough99