Skip to content

πŸ›‘οΈ Sentinel: [Medium] Fix Missing guild_only decorators on guild-dependent commands - #81

Open
keough99 wants to merge 1 commit into
mainfrom
sentinel-fix-guild-only-11541368955637625762
Open

πŸ›‘οΈ Sentinel: [Medium] Fix Missing guild_only decorators on guild-dependent commands#81
keough99 wants to merge 1 commit into
mainfrom
sentinel-fix-guild-only-11541368955637625762

Conversation

@keough99

Copy link
Copy Markdown
Contributor

🚨 Severity: Medium
πŸ’‘ Vulnerability: Missing guild_only decorator on commands requiring server context (ctx.guild).
🎯 Impact: Invoking these commands in a Direct Message (DM) causes an AttributeError (since ctx.guild is None), leading to an unhandled application exception and potential stack trace information leakage to the user.
πŸ”§ Fix: Added @commands.guild_only() to profile, bio, top, levelshop, resetrank, and levelset in leveler/commands.py.
βœ… Verification: Code syntax verified via py_compile. Commands will now be safely rejected if invoked in a DM.


PR created automatically by Jules for task 11541368955637625762 started by @keough99

…ndent commands

Several commands in the Leveler cog (`profile`, `bio`, `top`, `levelshop`, `resetrank`, `levelset`) accessed `ctx.guild` without the `@commands.guild_only()` decorator. If executed in a Direct Message (DM), `ctx.guild` is `None`, leading to an `AttributeError` and unhandled exceptions.

This commit adds `@commands.guild_only()` decorators to these commands to restrict their execution to guilds and prevent potential stack trace leakage.

Co-authored-by: keough99 <13394623+keough99@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant