feat: codex/major-change-002: toolbox parity + web search + MCP (one-shot) - #11
feat: codex/major-change-002: toolbox parity + web search + MCP (one-shot)#11Da3dalusCode wants to merge 9 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _get_exposed_entities(self) -> list[dict[str, Any]]: | ||
| if self._exposed_entities is not None: | ||
| return self._exposed_entities | ||
|
|
||
| exposed: list[dict[str, Any]] = [] | ||
| for state in self.hass.states.async_all(): | ||
| if async_should_expose(self.hass, "conversation", state.entity_id): |
There was a problem hiding this comment.
The new ToolsOrchestrator caches exposed entities by calling async_should_expose(self.hass, "conversation", state.entity_id). Because the agent ID is hard‑coded to the literal string "conversation", the check ignores any entity exposure configuration that is specific to this conversation entity (self.agent_id). In a multi‑agent setup this will expose whatever is configured for the default conversation agent, potentially allowing tool executions against entities that the user intentionally hid (or hiding entities that were explicitly exposed) for this agent. Pass self.agent_id to async_should_expose so the exposure logic matches the actual agent being used.
Useful? React with 👍 / 👎.
…e web search; caps
…ning; tighten Responses/Chat breadcrumbs and web-search gating
…y area/device; strings & polish
…area/device exposure; strings & polish
340733c to
a6aa4b6
Compare
3b76a60 to
043822c
Compare
1 participant
No description provided.