[BE-W3A-116] Web3 Signature Security and Auditing - Step 116#662
Merged
soomtochukwu merged 1 commit intoMay 29, 2026
Merged
Conversation
…hecks - Add strict 64-byte bounds checking for ed25519 signatures (reject any other length) - Return 401 status instead of 404 when no challenge found (prevents address enumeration) - Implement TOCTOU guard with atomic challenge consumption check - Use isChallengeFresh() helper for consistent expiration checking - Enforce proper error handling for all signature validation scenarios - Add comprehensive inline documentation for security-critical functions Acceptance Criteria Met: ✓ Login succeeds with Freighter wallet signatures (SEP-53 compliant) ✓ Incorrect signatures and expired challenges rejected with 401 status ✓ Redis blacklist lookups configured within latency budget ✓ Challenge atomicity prevents replay and concurrent consumption attacks Closes DXmakers#470
|
@k-deejah is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@k-deejah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria Met:
✓ Login succeeds with Freighter wallet signatures (SEP-53 compliant) ✓ Incorrect signatures and expired challenges rejected with 401 status ✓ Redis blacklist lookups configured within latency budget ✓ Challenge atomicity prevents replay and concurrent consumption attacks
Closes #470