feat: add dynamic bid cancellation and collateral refunds#590
Open
Benedict315 wants to merge 4 commits into
Open
feat: add dynamic bid cancellation and collateral refunds#590Benedict315 wants to merge 4 commits into
Benedict315 wants to merge 4 commits into
Conversation
|
@Benedict315 is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Benedict315 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution Description: SC-REG-028 - Dynamic Bid Cancellation and Collateral Refund Flows
Implementation Overview
Implement a bid cancellation system in the Job Registry contract that allows bidders to cancel active bids and receive collateral refunds with proper ownership validation and state management.
Key Components
Data Structures:
Add BidCancellation metadata tracking cancellation state and refund status
Map Job/Bid IDs to cancellation data
Cancellation Logic:
Validate bidder ownership and bid status (only active bids)
Prevent cancellation after job assignment
Execute atomic collateral refund or fail safely
Update bid status to Cancelled
IPFS Optimization:
Store cancellation reasons as IPFS CIDs instead of strings
Reduces on-chain footprint
Error Codes:
UnauthorizedCancellation, InvalidBidStatus, CollateralRefundFailed, NoCollateralToRefund
Testing:
Happy path: cancel active bid → receive refund
Edge cases: late cancellation, double-cancel, access control
Target: >90% coverage
closes #382