Skip to content

feat: add dynamic bid cancellation and collateral refunds#590

Open
Benedict315 wants to merge 4 commits into
DXmakers:mainfrom
Benedict315:sc-reg-028-bid-cancellation-refunds
Open

feat: add dynamic bid cancellation and collateral refunds#590
Benedict315 wants to merge 4 commits into
DXmakers:mainfrom
Benedict315:sc-reg-028-bid-cancellation-refunds

Conversation

@Benedict315
Copy link
Copy Markdown

Solution Description: SC-REG-028 - Dynamic Bid Cancellation and Collateral Refund Flows
Implementation Overview
Implement a bid cancellation system in the Job Registry contract that allows bidders to cancel active bids and receive collateral refunds with proper ownership validation and state management.

Key Components
Data Structures:

Add BidCancellation metadata tracking cancellation state and refund status
Map Job/Bid IDs to cancellation data

Cancellation Logic:

Validate bidder ownership and bid status (only active bids)
Prevent cancellation after job assignment
Execute atomic collateral refund or fail safely
Update bid status to Cancelled
IPFS Optimization:

Store cancellation reasons as IPFS CIDs instead of strings
Reduces on-chain footprint
Error Codes:

UnauthorizedCancellation, InvalidBidStatus, CollateralRefundFailed, NoCollateralToRefund

Testing:

Happy path: cancel active bid → receive refund
Edge cases: late cancellation, double-cancel, access control
Target: >90% coverage

closes #382

@Benedict315 Benedict315 requested a review from soomtochukwu as a code owner May 27, 2026 14:58
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

@Benedict315 is attempting to deploy a commit to the mAzI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@Benedict315 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SC-REG-028] Job Registry and Proposal Scaling Validation - Step 28

2 participants