Stop the divider defaulting its background to black#526
Merged
DROOdotFOO merged 1 commit intoJul 15, 2026
Merged
Conversation
ADR-0029 rule 2: an unpainted background emits no background. This clause defaulted bg to :black on its own, unlike every other element in the paint path -- element_renderer and border_renderer both went through this fix already (DROOdotFOO#520), the divider was missed. Visible on a modal: the surface fills its interior with the theme's :surface colour, but the divider punched a black cell through it because :black overrides the fill instead of showing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix, same class as #520.
render_visible_element(%{type: :divider, ...})inui_renderer.exdefaultedbgto:blackwhen no style was set. Every other element in the paint path(
element_renderer,border_renderer) went through this fix in #520; thedivider clause was outside that sweep and kept the old default.
Visible effect: a divider inside a modal punches an opaque black cell through
the modal's
:surfacefill, instead of showing it — see ADR-0029 rule 2 (anunpainted background means "show what is beneath", not "paint black").
No test pinned the old default. Full suite: 4712/4715 — the 3 failures are
pre-existing env-leak flakes (
TERM/metrics timing), unrelated and presenton master too.