⚡ Bolt: Optimize 3MF manifest scanning and gcode header parsing - #129
⚡ Bolt: Optimize 3MF manifest scanning and gcode header parsing#129DLANSAMA wants to merge 1 commit into
Conversation
- Optimize read_3mf_estimate manifest scanning into a single O(N) pass.
- Eliminate repeated split('/') list allocations on zip entry names.
- Add early loop break in _parse_gcode_header once estimates are found.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
read_3mf_estimate: normalizes path backslashes once per member name (n.replace("\\", "/")) and uses direct string equality and prefix/suffix checks instead of allocating list objects via repeated.split('/')calls._parse_gcode_header: breaks out of line iteration as soon as bothsecondsandgramsvalues are extracted.🎯 Why:
3MF estimate parsing was performing redundant list allocations and string replacements per zip entry, scanning the entry list multiple times. Header line parsing continued through remaining text even after finding both target fields.
📊 Impact:
🔬 Measurement:
Verified via micro-benchmark on 3MF archive manifests (
timeitshowed execution time drop from 1.14s to 0.26s over 20,000 iterations). All unit tests intests/test_slicer_estimate.pypass.PR created automatically by Jules for task 9347944549747451147 started by @DLANSAMA