🛡️ Sentinel: [MEDIUM] Add size safety limit for 3MF slice_info.config extraction - #128
🛡️ Sentinel: [MEDIUM] Add size safety limit for 3MF slice_info.config extraction#128DLANSAMA wants to merge 1 commit into
Conversation
… extraction Enforce a 10 MB safety limit check on slice_info.config within read_3mf_estimate to protect against memory exhaustion and Zip Bomb DoS when reading untrusted .3mf files. Add test_oversized_slice_info_falls_back_to_gcode in tests/test_slicer_estimate.py.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: Unbounded reading of Metadata/slice_info.config from .3mf files in read_3mf_estimate could consume arbitrary memory if an untrusted .3mf file contained a Zip Bomb or oversized XML payload.
🎯 Impact: Memory exhaustion or Denial of Service (DoS) when attempting to parse estimates from untrusted model archives.
🔧 Fix: Enforced a 10 MB SLICE_INFO_READ_BYTES safety limit check on info.file_size and bounded the read stream before parsing XML.
✅ Verification: Added unit test test_oversized_slice_info_falls_back_to_gcode in tests/test_slicer_estimate.py and verified that all tests, linter, and layer boundary checks pass.
PR created automatically by Jules for task 6578569325633671747 started by @DLANSAMA