Deployment fixes: CORS, wrangler vars, CD worker targeting#22
Merged
Deployment fixes: CORS, wrangler vars, CD worker targeting#22
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The --env flag doesn't work correctly with the Cloudflare vite plugin. Use --name harness-web-staging / harness-web instead. Also add staging vars to wrangler.jsonc (vars are not inherited by envs). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures deployment config survives future merges by having it on a PR branch:
frontend-cd.yml: use--nameflag instead of--envfor correct staging/prod worker targetingmain.py: CORS origins forharness.nz,staging.harness.nz, and*.workers.devwrangler.jsonc: public env vars (Convex URL, Clerk publishable key) for both environmentsThese were already pushed directly to staging as a hotfix but this PR ensures the branch history is clean.
🤖 Generated with Claude Code