Skip to content

remove race around ready bool#91

Merged
KevinJoiner merged 2 commits intomainfrom
remove-ready-func
Jun 18, 2025
Merged

remove race around ready bool#91
KevinJoiner merged 2 commits intomainfrom
remove-ready-func

Conversation

@KevinJoiner
Copy link
Copy Markdown
Contributor

@KevinJoiner KevinJoiner commented Jun 15, 2025

Started using this package for credit tracker ref EX-3667 so I am addressing some nits.

  1. Running tests with -race complains about the ready bool so I switched things to use an atomic variable.
  2. Add env tags to the settings struct

@KevinJoiner KevinJoiner requested a review from a team as a code owner June 15, 2025 13:54
@KevinJoiner KevinJoiner requested review from JamesReate and elffjs June 15, 2025 13:54
@linear
Copy link
Copy Markdown

linear bot commented Jun 15, 2025

@KevinJoiner KevinJoiner merged commit 97da170 into main Jun 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants