chore(deps): pin shell-quote to >=1.8.4 to clear critical advisory#1120
Open
TaprootFreak wants to merge 1 commit into
Open
chore(deps): pin shell-quote to >=1.8.4 to clear critical advisory#1120TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
npm audit flags shell-quote@1.8.1 (quote() does not escape newlines, GHSA critical) as the repo's single critical. It is a transitive dev-only dependency (react-scripts build tooling + @trezor devtools via react-native), not in the production bundle, but the PR review bot counts it on every PR. Add a top-level override to 1.8.4 (patched); surgical lockfile change, shell-quote 1.8.1 -> 1.8.4 only. Critical count: 1 -> 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Hebt
shell-quoteperoverridesauf^1.8.4(gepatcht). Der PR-Review-Bot meldet auf jedem PR1 critical vulnerability— das istshell-quote@1.8.1(quote()escaped keine Newlines, GHSA critical).Kontext
shell-quoteist eine transitive Dev-Only-Dependency:react-scripts→ webpack-dev-server / react-dev-utils / launch-editor@trezor/connect-web→ react-native → react-devtools-coreNichts davon landet im Production-Bundle des Widgets — die Lücke ist nicht in der Runtime-Angriffsfläche. Der Bot zählt aber den repo-weiten
npm audit-Critical-Count, unabhängig vom Diff. Vorbestehend auf develop, nicht von einem Feature-PR eingeführt.Änderung
Chirurgisch: nur
shell-quote1.8.1 → 1.8.4 im Lockfile + einoverrides-Eintrag.npm auditcritical: 1 → 0 (die 62 high bleiben bewusst unangetastet — separater Scope). Production-Build lokal grün.Klärt die kritische Bot-Meldung für diesen und alle künftigen PRs.