chore: harden repo CI, docs, license and native logging#28
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
chore: harden repo CI, docs, license and native logging#28joshuakrueger-dfx wants to merge 1 commit into
joshuakrueger-dfx wants to merge 1 commit into
Conversation
Build the native Android (example APK) and iOS (example, --no-codesign) code in CI so native-only changes can no longer pass every check while breaking the consuming app's build. Drop the stale flutter-create template tests across Android, iOS and macOS (and their Xcode/Gradle wiring) that exercised a getPlatformVersion the plugin never implemented; remove the matching template getPlatformVersion handler from the macOS plugin so it is consistent with the Android and iOS bridges. Add a real MIT LICENSE, a source-accurate README and CHANGELOG (0.0.1-0.0.8), fill pubspec metadata, and log previously swallowed native error paths. Closes DFXswiss#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Repo hardening across CI, tests, docs, license and native error logging. Each item from #27 addressed; scope kept tight and consistent with the existing project conventions.
High priority
pull-request.yamlgains two jobs alongside the existing flutter/go/yaml-lint:android(ubuntu, JDK 17,flutter build apk --debugofexample/) andios(macos-latest,flutter build ios --no-codesignofexample/). A native-only change can no longer pass every check while breaking the consuming app's build.flutter createleftovers that exercised agetPlatformVersionthe plugin never implements: the Android Kotlin test (wrong packagecom.cakewallet.bitbox) and the iOSRunnerTests.swift, including a clean removal of theRunnerTeststarget from the Xcode project, scheme and Podfile (no dangling refs). The now-orphaned JUnit5/mockito wiring inandroid/build.gradleis removed too. For consistency the identical macOS template stub (test + the templategetPlatformVersionhandler) is removed as well.Medium priority
run_build_tool_android.sh,ffigen_config.yaml). Every referenced API verified against source.description, plushomepage/repository/issue_tracker.Low priority
InitBitBoxOperation,CloseOperation,ConnectBitBoxOperation) now emitLog.w("bitbox_flutter", ...)on the error path; no behaviour change.Out of scope per the issue: no full native unit-test coverage, vendored gomobile artifacts left as-is.
Verification (local, Flutter 3.41.6 — the CI pin)
dart formatclean ·flutter analyze --fatal-infosclean ·flutter test11/11go vet+go testgreenflutter build apk --debug(example) → builtapp-debug.apkflutter build ios --no-codesign(example) → builtRunner.appflutter build macos --debug(example) → built, confirming the macOS project edits compile