fix(monitoring): remove delisted XT price-deviation checks#3881
Open
Danswar wants to merge 2 commits into
Open
fix(monitoring): remove delisted XT price-deviation checks#3881Danswar wants to merge 2 commits into
Danswar wants to merge 2 commits into
Conversation
XT delisted the DEURO/USDT, DEPS/USDT and JUSD/USDT pairs, so getPriceFrom(XT, ...) throws 'pair not supported' on every run. As the first call in getXtPriceDeviation(), it aborted the whole fetch() cron (Kraken/Binance volume never emitted) and logged ERROR every cycle. With all three XT pairs gone there is nothing left to monitor on XT, so remove getXtPriceDeviation() entirely along with the now-unused PricingService/AssetService injections and imports. Kraken and Binance volume reporting is unchanged and now always emits.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XT delisted the DEURO/USDT, DEPS/USDT and JUSD/USDT pairs.
ExchangeObserver.getXtPriceDeviation()callspricingService.getPriceFrom(PriceSource.XT, ...)for each, and XT now throwsBadRequestException: XT: pair ... not supported.Because the DEURO lookup is the first call and nothing catches it, the throw aborts the entire
fetch()cron — so Kraken and Binance volume are never emitted that cycle — and it logs an ERROR every 10 minutes (~6/h on dfxdev; the bucket showed up in the error-zero log review).Fix
With all three XT pairs delisted there is nothing left to monitor on XT, so this removes
getXtPriceDeviation()entirely rather than hardening it. Also drops the now-unusedPricingService/AssetServiceinjections and imports.fetch()now pushes only Kraken + Binance volume and always emits (the abort is gone).PriceSource.XT/XtServicestays wired inpricing.service.tsand liquidity-management; only the dead monitoring calls are removed.XT-dEURO-USDT/XT-DEPS-USDT/XT-JUSD-USDT);health.controllerhas no exchange/deviation thresholds, so health status is unaffected.tsc --noEmitclean.Note
Any monitoring dashboard panel showing those three XT deviations will have no further data — but they are already empty since the delisting. No working panel is affected.