Skip to content

fix(lightning): restore CA-validated https agent for LNbits requests #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidleomay merged 1 commit into from
Jun 11, 2026
+6 −3
Merged

fix(lightning): restore CA-validated https agent for LNbits requests #3869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/integration/lightning/lightning-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ import { CoinOnly } from 'src/integration/blockchain/shared/util/blockchain-clie
import { LightningHelper } from './lightning-helper';

export class LightningClient implements CoinOnly {
private readonly lndAgent: Agent;
// LND and LNbits both serve the self-signed LND certificate (reached via
// private IP on PRD), so requests must be verified against this CA, not the system CAs
private readonly tlsAgent: Agent;

constructor(private readonly http: HttpService) {
this.lndAgent = new Agent({ ca: Config.blockchain.lightning.certificate });
this.tlsAgent = new Agent({ ca: Config.blockchain.lightning.certificate });
}

// --- LND --- //
Expand Down Expand Up @@ -363,13 +365,14 @@ export class LightningClient implements CoinOnly {

private httpLnBitsConfig(params?: any): HttpRequestConfig {
return {
httpsAgent: this.tlsAgent,
params: { 'api-key': Config.blockchain.lightning.lnbits.apiKey, ...params },
};
}

private httpLndConfig(): HttpRequestConfig {
return {
httpsAgent: this.lndAgent,
httpsAgent: this.tlsAgent,
headers: { 'Grpc-Metadata-macaroon': Config.blockchain.lightning.lnd.adminMacaroon },
};
}
Expand Down