fix(config): restore LIGHTNING_API_CERTIFICATE env fallback for Azure#3867
Merged
Conversation
When LIGHTNING_API_CERTIFICATE_PATH is not set (Azure App Service has no cert file mount), fall back to reading the inline PEM from LIGHTNING_API_CERTIFICATE using the legacy <br> newline separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#3861 replaced the inline LIGHTNING_API_CERTIFICATE env var with LIGHTNING_API_CERTIFICATE_PATH (file-based). On Azure App Service there is no cert file mount, so readCert() returns undefined and LND TLS connections break.
Fix
When LIGHTNING_API_CERTIFICATE_PATH is set, read from file (Docker). When not set, fall back to LIGHTNING_API_CERTIFICATE with
split (Azure).
Post-cutover
After dfxprd cutover, the fallback can be removed since the cert file mount will always be available.