feat(realunit): overhaul transaction receipt PDF#3865
Draft
TaprootFreak wants to merge 1 commit into
Draft
Conversation
Add language override parameter to receipt DTOs so the app can request
receipts in the user's current locale instead of the profile language.
Extend the RealUnit receipt with the fields requested by RealUnit
Schweiz AG: ISIN-qualified description ("Namenaktie / Registerwertrecht"),
unit price per share, fee disclosure ("spesenfrei"), execution date+time,
buyer name, wallet address, full tx hash, and payment method.
Add RealUnit-specific i18n keys in all four languages (DE/EN/FR/IT).
Refactor generatePdfInvoice and generateMultiPdfInvoice to conditionally
render the enhanced layout when brand is REALUNIT.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RealUnitSingleReceiptPdfDto,RealUnitMultiReceiptPdfDto) now accept an optionallanguageparameter so the app can request receipts in the user's current localeContext
Requested by RealUnit Schweiz AG (Dani Stüssi) to bring transaction receipts in line with their corporate template and Swiss financial standards.
Changed files
realunit-pdf.dto.tslanguage?: PdfLanguageto both receipt DTOs{de,en,fr,it}/invoice.jsonrealunit_receipti18n section (13 keys each)swiss-qr.service.tsSwissQRBillTableData, adddrawReceiptDetails(), refactorgeneratePdfInvoice+generateMultiPdfInvoicefor REALUNIT brandrealunit.controller.tsdto.languageandjwt.addressto service methodsTest plan
POST /v1/realunit/transactions/receipt/singlewithlanguage: "DE"— verify German description with ISIN, unit price column, details sectionPOST /v1/realunit/transactions/receipt/multi— verify per-transaction unit prices and shared details section