Repository navigation
Backfill of 'Register or renew temporary use of land or buildings to keep livestock' form - Runner - #1361
Open
Scullyon wants to merge 2 commits into
Open
Backfill of 'Register or renew temporary use of land or buildings to keep livestock' form - Runner#1361Scullyon wants to merge 2 commits into
Scullyon wants to merge 2 commits into
Conversation
# Conflicts: # src/server/routes/homepage.js # src/server/services/submissionService.test.js
|
jbarnsley10
reviewed
Nov 12, 2026
|
|
||
| const { accessToken } = request.auth.credentials | ||
|
|
||
| // Before the saved forms are read, so they include the submissions linked |
Contributor
There was a problem hiding this comment.
A bit chicken-and-egg. Do we read the forms first to determine if linking has already been done (and therefore don;t need a 'link' API call each time) or do we check if linked (using a 'link' API call) even though this will become redundant after the first time it happens for this form/user.
Is there a way to tell forms are linked purely on the 'getForms'-type call, because if there was, we could avoid the extra 'link' API call every time?
jbarnsley10
reviewed
Nov 12, 2026
| * How long the homepage waits for earlier submissions to be linked, so a slow | ||
| * submission API delays the page by no more than this | ||
| */ | ||
| const LINK_SUBMISSIONS_TIMEOUT_MS = 5000 |
Contributor
There was a problem hiding this comment.
Does this give ample time for all a user's previous submissions to be linked?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial backfill / submission linking functionality.