Repository navigation
feature/DF-1206 reuse answers - #1343
Merged
Merged
Conversation
davidjamesstone
force-pushed
the
feature/DF-1206-reuse-answers-copy-action
branch
from
November 3, 2026 12:36
af11f25 to
1c86cd2
Compare
…ve code reuse and clarity
…error handling in tests
davidjamesstone
marked this pull request as ready for review
November 9, 2026 13:06
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
| ) | ||
| } | ||
|
|
||
| const formVersionHasChanged = |
Contributor
There was a problem hiding this comment.
Are we happy that a change of version number is sufficient a check to say there are changes in the form? What if it was published at say version 100, then changed and published again at version 101, then the draft revert back to equivalent of v 100, then published as v102? i.e. no difference in definition between v100 and v102 yet this method would report things had changed.
Very edge case though
Contributor
Author
There was a problem hiding this comment.
That's the guidance/AC. Might be worth raising when we go through it tomorrow with the team.
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
| * it's a sentence break. | ||
| * @param {unknown} str - Gracefully handles null, undefined and non-string values. | ||
| */ | ||
| export function escapeFileLabel(str) { |
jbarnsley10
reviewed
Nov 9, 2026
jbarnsley10
reviewed
Nov 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/DF-1206
Copy previous submission.
submissionPayload.meta.custom = { action: 'copy', actionReferenceNumber: 'previous reference number' }Copy form: Interstitial page 1 (displayed for all)
Copy form: Interstitial page 2 (only displayed if the form definition version has changed or there are declaration components)
Copy form: Interstitial page 3 (only displayed if the form definition version has changed or there are declaration components)
