Repository navigation
DF-1497: Add failing tests for stale grid references after update - #479
Merged
Merged
Conversation
`getFeaturesManager.updateFeature` assigns both grid reference properties before it applies the new geometry, and both are derived from `feature.geometry`, so an updated point, line or shape keeps the grid reference of its previous position while its coordinates move. Adds unit tests covering add and update for each geometry type. The three grid reference assertions for `updateFeature` fail until the ordering is corrected; `getFeaturesManager` is exported so they can be driven directly. No behaviour change.
|
davidjamesstone
approved these changes
Oct 9, 2026
Contributor
Author
|
Lets merge along with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



getFeaturesManager.updateFeatureassigns both grid reference properties before it applies the new geometry, and both are derived fromfeature.geometry, so an updated point, line or shape keeps the grid reference of its previous position while its coordinates move.Adds unit tests covering add and update for each geometry type. The three grid reference assertions for
updateFeaturefail until the ordering is corrected;getFeaturesManageris exported so they can be driven directly.No behaviour change.
Proposed change
Jira ticket: https://eaflood.atlassian.net/browse/DF-1497
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).