Skip to content

Bug Fix: Use Short Description in Error Messages for Composite Question Types - #473

Merged
Scullyon merged 2 commits into
mainfrom
feat/DF-1401-error-message-should-use-short-description-for-date-questions
Oct 5, 2026
Merged

Scullyon merged 2 commits into
mainfrom
feat/DF-1401-error-message-should-use-short-description-for-date-questions

Conversation

@Scullyon

@Scullyon Scullyon commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Jira ticket: https://eaflood.atlassian.net/browse/DF-1401

NOTE:

  • Fix is here
  • Linting fixes for pre-existing linting issues are the remaineder.

Type of change

Error messages should use short description for date and other composite questions, instead of the error title. Also, use

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@sonarqubecloud

Copy link
Copy Markdown

@jbarnsley10 jbarnsley10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although it might have been cleaner to do the type fixes in a separate PR ;-)

@Scullyon
Scullyon merged commit c01ab4b into main Oct 5, 2026
25 checks passed
@Scullyon
Scullyon deleted the feat/DF-1401-error-message-should-use-short-description-for-date-questions branch October 5, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants